[PATCH 1/5] [ARC] Update handling AUX-registers.
Claudiu Zissulescu
claziss@synopsys.com
Thu Aug 2 13:06:00 GMT 2018
Hi Nick,
> If you were the maintainer for the ARC target you could self-approve these
> patches you know...
I am not, but I am interested :) in the if part...
>
> > + /* For compatibility reasons, an aux register can
> > + be spelled with upper or lower case
> > + letters. */
> > + tmpp = strdup (p);
> > + for (pp = tmpp; *pp; ++pp) *pp = TOLOWER (*pp);
> > +
> > + auxr = hash_find (arc_aux_hash, tmpp);
>
> Memory leak - you do not free tmpp. Trivial I know, but I have started
> having to fix things like this in Fedora land.
Many thanks, I will resubmit the patch with the fix. I also need to recheck the ARC port for memory leaks.
Thank you,
Claudiu
More information about the Binutils
mailing list