[PATCH 2/3] Enable Intel CLDEMOTE instructions.

[H.J. Lu]

On Tue, Apr 17, 2018 at 3:16 AM, Tsimbalist, Igor V
<igor.v.tsimbalist@intel.com> wrote:
>> -----Original Message-----
>> From: Jan Beulich [mailto:JBeulich@suse.com]
>> Sent: Tuesday, April 17, 2018 11:10 AM
>> To: Tsimbalist, Igor V <igor.v.tsimbalist@intel.com>
>> Cc: Lu, Hongjiu <hongjiu.lu@intel.com>; binutils@sourceware.org
>> Subject: RE: [PATCH 2/3] Enable Intel CLDEMOTE instructions.
>>
>> >>> On 16.04.18 at 23:49, <igor.v.tsimbalist@intel.com> wrote:
>> >>  -----Original Message-----
>> >> From: Jan Beulich [mailto:jbeulich@suse.com]
>> >> Sent: Sunday, April 15, 2018 3:30 PM
>> >> To: Tsimbalist, Igor V <igor.v.tsimbalist@intel.com>
>> >> Cc: Lu, Hongjiu <hongjiu.lu@intel.com>; binutils@sourceware.org
>> >> Subject: Re: [PATCH 2/3] Enable Intel CLDEMOTE instructions.
>> >>
>> >> >>> "Tsimbalist, Igor V" <igor.v.tsimbalist@intel.com> 04/13/18 2:13
>> PM
>> >> >>>
>> >> >opcode/
>> >> >* i386-dis.c (dis386_twobyte): Add cldemote.
>> >>
>> >> This is wrong: CLDEMOTE isn't all of 0F 1C, but only 0F 1C /0, and only
>> with
>> >> none of 66, F3, or F2 prefixes. With that corrected, quite a bit of what you
>> >> drop
>> >> from the NOP testcases can and should also be left untouched.
>> >
>> > Yes, you are right. The updated patch is attached.
>>
>> Perhaps in the NOPs tests you alter, instead of commenting out the
>> two lines each, you'd better replace them with e.g. a 0F 1C /1 form?
>
> Oops. Just checked the fixes. Good suggestion. I will do this as a separate fix now.
> I will post the update in this thread. Is it ok to check this in without separate approval?
>

Yes.

-- 
H.J.