[PATCH 2/2] MIPS/LD/testsuite: Update `run_dump_test' cases for non-DSO targets
Maciej W. Rozycki
macro@mips.com
Thu Apr 12 13:24:00 GMT 2018
Mark these `run_dump_test' cases across `ld-mips-elf/mips-elf.exp' that
are run unconditionally and require shared library support for exclusion
for targets that do not have such support, removing these failures:
FAIL: MIPS BAL/JALX in PIC mode
FAIL: microMIPS BAL/JALX in PIC mode
FAIL: MIPS BAL/JALX in PIC mode (ignore branch ISA)
FAIL: microMIPS BAL/JALX in PIC mode (ignore branch ISA)
FAIL: ld-mips-elf/hash1a
FAIL: ld-mips-elf/hash1b
FAIL: ld-mips-elf/hash1c
with `mipsel-ps2-elf' and `mips64el-ps2-elf' targets. Tests that are
guarded with `linux_gnu' will have to be reviewed separately.
ld/
* testsuite/ld-mips-elf/bal-jalx-pic.d: Only run for
`check_shared_lib_support' targets.
* testsuite/ld-mips-elf/bal-jalx-pic-n32.d: Likewise.
* testsuite/ld-mips-elf/bal-jalx-pic-n64.d: Likewise.
* testsuite/ld-mips-elf/bal-jalx-pic-micromips.d: Likewise.
* testsuite/ld-mips-elf/bal-jalx-pic-micromips-n32.d: Likewise.
* testsuite/ld-mips-elf/bal-jalx-pic-micromips-n64.d: Likewise.
* testsuite/ld-mips-elf/bal-jalx-pic-ignore.d: Likewise.
* testsuite/ld-mips-elf/bal-jalx-pic-ignore-n32.d: Likewise.
* testsuite/ld-mips-elf/bal-jalx-pic-ignore-n64.d: Likewise.
* testsuite/ld-mips-elf/bal-jalx-pic-ignore-micromips.d:
Likewise.
* testsuite/ld-mips-elf/bal-jalx-pic-ignore-micromips-n32.d:
Likewise.
* testsuite/ld-mips-elf/bal-jalx-pic-ignore-micromips-n64.d:
Likewise.
* testsuite/ld-mips-elf/hash1a.d: Likewise.
* testsuite/ld-mips-elf/hash1b.d: Likewise.
* testsuite/ld-mips-elf/hash1c.d: Likewise.
* testsuite/ld-mips-elf/relax-jalr-n32-shared.d: Likewise.
* testsuite/ld-mips-elf/relax-jalr-n64-shared.d: Likewise.
---
Hi,
Self-approved and will commit it along with 1/2.
Maciej
---
ld/testsuite/ld-mips-elf/bal-jalx-pic-ignore-micromips-n32.d | 1 +
ld/testsuite/ld-mips-elf/bal-jalx-pic-ignore-micromips-n64.d | 1 +
ld/testsuite/ld-mips-elf/bal-jalx-pic-ignore-micromips.d | 1 +
ld/testsuite/ld-mips-elf/bal-jalx-pic-ignore-n32.d | 1 +
ld/testsuite/ld-mips-elf/bal-jalx-pic-ignore-n64.d | 1 +
ld/testsuite/ld-mips-elf/bal-jalx-pic-ignore.d | 1 +
ld/testsuite/ld-mips-elf/bal-jalx-pic-micromips-n32.d | 1 +
ld/testsuite/ld-mips-elf/bal-jalx-pic-micromips-n64.d | 1 +
ld/testsuite/ld-mips-elf/bal-jalx-pic-micromips.d | 1 +
ld/testsuite/ld-mips-elf/bal-jalx-pic-n32.d | 1 +
ld/testsuite/ld-mips-elf/bal-jalx-pic-n64.d | 1 +
ld/testsuite/ld-mips-elf/bal-jalx-pic.d | 1 +
ld/testsuite/ld-mips-elf/hash1a.d | 1 +
ld/testsuite/ld-mips-elf/hash1b.d | 1 +
ld/testsuite/ld-mips-elf/hash1c.d | 1 +
ld/testsuite/ld-mips-elf/relax-jalr-n32-shared.d | 1 +
ld/testsuite/ld-mips-elf/relax-jalr-n64-shared.d | 1 +
17 files changed, 17 insertions(+)
binutils-mips-ld-test-shared.diff
Index: binutils/ld/testsuite/ld-mips-elf/bal-jalx-pic-ignore-micromips-n32.d
===================================================================
--- binutils.orig/ld/testsuite/ld-mips-elf/bal-jalx-pic-ignore-micromips-n32.d 2018-04-11 17:30:16.000000000 +0100
+++ binutils/ld/testsuite/ld-mips-elf/bal-jalx-pic-ignore-micromips-n32.d 2018-04-11 17:32:11.556123260 +0100
@@ -3,4 +3,5 @@
#as: -EB -n32 -march=from-abi
#ld: -EB -Ttext 0x1c000000 -e 0x1c000000 -shared --ignore-branch-isa
#objdump: -dr --prefix-addresses --show-raw-insn
+#target: [check_shared_lib_support]
#dump: bal-jalx-pic-ignore-micromips.d
Index: binutils/ld/testsuite/ld-mips-elf/bal-jalx-pic-ignore-micromips-n64.d
===================================================================
--- binutils.orig/ld/testsuite/ld-mips-elf/bal-jalx-pic-ignore-micromips-n64.d 2018-04-11 17:30:16.000000000 +0100
+++ binutils/ld/testsuite/ld-mips-elf/bal-jalx-pic-ignore-micromips-n64.d 2018-04-11 17:32:32.018063535 +0100
@@ -3,4 +3,5 @@
#as: -EB -64 -march=from-abi
#ld: -EB -Ttext 0x1c000000 -e 0x1c000000 -shared --ignore-branch-isa
#objdump: -dr --prefix-addresses --show-raw-insn
+#target: [check_shared_lib_support]
#dump: bal-jalx-pic-ignore-micromips.d
Index: binutils/ld/testsuite/ld-mips-elf/bal-jalx-pic-ignore-micromips.d
===================================================================
--- binutils.orig/ld/testsuite/ld-mips-elf/bal-jalx-pic-ignore-micromips.d 2018-04-11 17:30:16.000000000 +0100
+++ binutils/ld/testsuite/ld-mips-elf/bal-jalx-pic-ignore-micromips.d 2018-04-11 17:32:53.508331847 +0100
@@ -3,6 +3,7 @@
#as: -EB -32
#ld: -EB -Ttext 0x1c000000 -e 0x1c000000 -shared --ignore-branch-isa
#objdump: -dr --prefix-addresses --show-raw-insn
+#target: [check_shared_lib_support]
.*: +file format .*mips.*
Index: binutils/ld/testsuite/ld-mips-elf/bal-jalx-pic-ignore-n32.d
===================================================================
--- binutils.orig/ld/testsuite/ld-mips-elf/bal-jalx-pic-ignore-n32.d 2018-04-11 17:30:16.000000000 +0100
+++ binutils/ld/testsuite/ld-mips-elf/bal-jalx-pic-ignore-n32.d 2018-04-11 17:33:10.392806862 +0100
@@ -3,4 +3,5 @@
#as: -EB -n32 -march=from-abi
#ld: -EB -Ttext 0x1c000000 -e 0x1c000000 -shared --ignore-branch-isa
#objdump: -dr --prefix-addresses --show-raw-insn
+#target: [check_shared_lib_support]
#dump: bal-jalx-pic-ignore.d
Index: binutils/ld/testsuite/ld-mips-elf/bal-jalx-pic-ignore-n64.d
===================================================================
--- binutils.orig/ld/testsuite/ld-mips-elf/bal-jalx-pic-ignore-n64.d 2018-04-11 17:30:16.000000000 +0100
+++ binutils/ld/testsuite/ld-mips-elf/bal-jalx-pic-ignore-n64.d 2018-04-11 17:33:15.303431312 +0100
@@ -3,4 +3,5 @@
#as: -EB -64 -march=from-abi
#ld: -EB -Ttext 0x1c000000 -e 0x1c000000 -shared --ignore-branch-isa
#objdump: -dr --prefix-addresses --show-raw-insn
+#target: [check_shared_lib_support]
#dump: bal-jalx-pic-ignore.d
Index: binutils/ld/testsuite/ld-mips-elf/bal-jalx-pic-ignore.d
===================================================================
--- binutils.orig/ld/testsuite/ld-mips-elf/bal-jalx-pic-ignore.d 2018-04-11 17:30:16.000000000 +0100
+++ binutils/ld/testsuite/ld-mips-elf/bal-jalx-pic-ignore.d 2018-04-11 17:33:21.851079115 +0100
@@ -3,6 +3,7 @@
#as: -EB -32
#ld: -EB -Ttext 0x1c000000 -e 0x1c000000 -shared --ignore-branch-isa
#objdump: -dr --prefix-addresses --show-raw-insn
+#target: [check_shared_lib_support]
.*: +file format .*mips.*
Index: binutils/ld/testsuite/ld-mips-elf/bal-jalx-pic-micromips-n32.d
===================================================================
--- binutils.orig/ld/testsuite/ld-mips-elf/bal-jalx-pic-micromips-n32.d 2018-04-11 17:30:16.000000000 +0100
+++ binutils/ld/testsuite/ld-mips-elf/bal-jalx-pic-micromips-n32.d 2018-04-11 17:33:40.059789969 +0100
@@ -2,5 +2,6 @@
#source: ../../../gas/testsuite/gas/mips/branch-addend-micromips.s
#as: -EB -n32 -march=from-abi
#ld: -EB -Ttext 0x1c000000 -e 0x1c000000 -shared
+#target: [check_shared_lib_support]
#error: \A[^\n]*: in function `bar':\n
#error: \(\.text\+0x1014\): unsupported branch between ISA modes\Z
Index: binutils/ld/testsuite/ld-mips-elf/bal-jalx-pic-micromips-n64.d
===================================================================
--- binutils.orig/ld/testsuite/ld-mips-elf/bal-jalx-pic-micromips-n64.d 2018-04-11 17:30:16.000000000 +0100
+++ binutils/ld/testsuite/ld-mips-elf/bal-jalx-pic-micromips-n64.d 2018-04-11 17:33:44.005785588 +0100
@@ -2,5 +2,6 @@
#source: ../../../gas/testsuite/gas/mips/branch-addend-micromips.s
#as: -EB -64 -march=from-abi
#ld: -EB -Ttext 0x1c000000 -e 0x1c000000 -shared
+#target: [check_shared_lib_support]
#error: \A[^\n]*: in function `bar':\n
#error: \(\.text\+0x1014\): unsupported branch between ISA modes\Z
Index: binutils/ld/testsuite/ld-mips-elf/bal-jalx-pic-micromips.d
===================================================================
--- binutils.orig/ld/testsuite/ld-mips-elf/bal-jalx-pic-micromips.d 2018-04-11 17:30:16.000000000 +0100
+++ binutils/ld/testsuite/ld-mips-elf/bal-jalx-pic-micromips.d 2018-04-11 17:33:47.025224054 +0100
@@ -2,5 +2,6 @@
#source: ../../../gas/testsuite/gas/mips/branch-addend-micromips.s
#as: -EB -32
#ld: -EB -Ttext 0x1c000000 -e 0x1c000000 -shared
+#target: [check_shared_lib_support]
#error: \A[^\n]*: in function `bar':\n
#error: \(\.text\+0x1014\): unsupported branch between ISA modes\Z
Index: binutils/ld/testsuite/ld-mips-elf/bal-jalx-pic-n32.d
===================================================================
--- binutils.orig/ld/testsuite/ld-mips-elf/bal-jalx-pic-n32.d 2018-04-11 17:30:16.000000000 +0100
+++ binutils/ld/testsuite/ld-mips-elf/bal-jalx-pic-n32.d 2018-04-11 17:33:50.414178490 +0100
@@ -2,5 +2,6 @@
#source: ../../../gas/testsuite/gas/mips/branch-addend.s
#as: -EB -n32 -march=from-abi
#ld: -EB -Ttext 0x1c000000 -e 0x1c000000 -shared
+#target: [check_shared_lib_support]
#error: \A[^\n]*: in function `bar':\n
#error: \(\.text\+0x1014\): unsupported branch between ISA modes\Z
Index: binutils/ld/testsuite/ld-mips-elf/bal-jalx-pic-n64.d
===================================================================
--- binutils.orig/ld/testsuite/ld-mips-elf/bal-jalx-pic-n64.d 2018-04-11 17:30:16.000000000 +0100
+++ binutils/ld/testsuite/ld-mips-elf/bal-jalx-pic-n64.d 2018-04-11 17:33:54.334736028 +0100
@@ -2,5 +2,6 @@
#source: ../../../gas/testsuite/gas/mips/branch-addend.s
#as: -EB -64 -march=from-abi
#ld: -EB -Ttext 0x1c000000 -e 0x1c000000 -shared
+#target: [check_shared_lib_support]
#error: \A[^\n]*: in function `bar':\n
#error: \(\.text\+0x1014\): unsupported branch between ISA modes\Z
Index: binutils/ld/testsuite/ld-mips-elf/bal-jalx-pic.d
===================================================================
--- binutils.orig/ld/testsuite/ld-mips-elf/bal-jalx-pic.d 2018-04-11 17:30:16.000000000 +0100
+++ binutils/ld/testsuite/ld-mips-elf/bal-jalx-pic.d 2018-04-11 17:33:57.288034373 +0100
@@ -2,5 +2,6 @@
#source: ../../../gas/testsuite/gas/mips/branch-addend.s
#as: -EB -32
#ld: -EB -Ttext 0x1c000000 -e 0x1c000000 -shared
+#target: [check_shared_lib_support]
#error: \A[^\n]*: in function `bar':\n
#error: \(\.text\+0x1014\): unsupported branch between ISA modes\Z
Index: binutils/ld/testsuite/ld-mips-elf/hash1a.d
===================================================================
--- binutils.orig/ld/testsuite/ld-mips-elf/hash1a.d 2018-04-11 17:30:16.000000000 +0100
+++ binutils/ld/testsuite/ld-mips-elf/hash1a.d 2018-04-11 17:35:51.514347066 +0100
@@ -1,4 +1,5 @@
#source: hash1.s
#ld: -shared --hash-style=sysv
#objdump: -dr
+#target: [check_shared_lib_support]
#pass
Index: binutils/ld/testsuite/ld-mips-elf/hash1b.d
===================================================================
--- binutils.orig/ld/testsuite/ld-mips-elf/hash1b.d 2018-04-11 17:30:16.000000000 +0100
+++ binutils/ld/testsuite/ld-mips-elf/hash1b.d 2018-04-11 17:35:59.261932454 +0100
@@ -1,3 +1,4 @@
#source: hash1.s
#ld: -shared --hash-style=both
+#target: [check_shared_lib_support]
#error: .gnu.hash is incompatible with the MIPS ABI
Index: binutils/ld/testsuite/ld-mips-elf/hash1c.d
===================================================================
--- binutils.orig/ld/testsuite/ld-mips-elf/hash1c.d 2018-04-11 17:30:16.000000000 +0100
+++ binutils/ld/testsuite/ld-mips-elf/hash1c.d 2018-04-11 17:38:28.805377900 +0100
@@ -1,3 +1,4 @@
#source: hash1.s
#ld: -shared --hash-style=gnu
+#target: [check_shared_lib_support]
#error: .gnu.hash is incompatible with the MIPS ABI
Index: binutils/ld/testsuite/ld-mips-elf/relax-jalr-n32-shared.d
===================================================================
--- binutils.orig/ld/testsuite/ld-mips-elf/relax-jalr-n32-shared.d 2018-04-11 17:30:16.000000000 +0100
+++ binutils/ld/testsuite/ld-mips-elf/relax-jalr-n32-shared.d 2018-04-11 17:40:09.638553415 +0100
@@ -3,6 +3,7 @@
#as: -march=from-abi -KPIC -n32 -EB
#objdump: --prefix-addresses -d --show-raw-insn
#ld: -shared -melf32btsmipn32
+#target: [check_shared_lib_support]
.*: file format elf.*mips.*
Index: binutils/ld/testsuite/ld-mips-elf/relax-jalr-n64-shared.d
===================================================================
--- binutils.orig/ld/testsuite/ld-mips-elf/relax-jalr-n64-shared.d 2018-04-11 17:30:16.000000000 +0100
+++ binutils/ld/testsuite/ld-mips-elf/relax-jalr-n64-shared.d 2018-04-11 17:40:20.178961141 +0100
@@ -3,6 +3,7 @@
#as: -march=from-abi -KPIC -64 -EB
#objdump: --prefix-addresses -d --show-raw-insn
#ld: -shared -melf64btsmip
+#target: [check_shared_lib_support]
.*: file format elf.*mips.*
More information about the Binutils
mailing list