Yet another fill-1 test fix

Alan Modra amodra@gmail.com
Wed Oct 25 07:53:00 GMT 2017


tic4x fails due to being a 4 octets per byte target, while tic54x is 2
octets per byte.

mmix still fails with
fill-1.s:4: Error: unknown pseudo-op: `.l1:'
fill-1.s:6: Error: unknown pseudo-op: `.l2:'
fill-1.s:3: Error: .space specifies non-absolute value

and if the labels are changed to L1 and L2 to avoid the mmix fail then
mep-elf fails with
fill-1.s:3: Error: .space specifies non-absolute value
due to generating a fancy RELC reloc that isn't resolved.

Since both of those look like they ought to be investigated by the
target maintainers, I'm tweaking the test to fail on both targets.
That's not because I think the bugs ought to be fixed, but just that I
wasn't comfortable sweeping this under the rug myself by adding mmix
or mep to not-target.

diff --git a/gas/ChangeLog b/gas/ChangeLog
index 833e41c..4d7dcce 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,19 +1,24 @@
+2017-10-25  Alan Modra  <amodra@gmail.com>
+
+	* testsuite/gas/all/fill-1.d: Exclude tic4x and tic54x.
+	* testsuite/gas/all/fill-1.s: Use L1 rather than .L1.
+
 2017-10-24  Andrew Waterman  <andrew@sifive.com>
 
 	* testsuite/gas/riscv/c-addi16sp-fail.d: New test.
-	testsuite/gas/riscv/c-addi16sp-fail.l: Likewise.
-	testsuite/gas/riscv/c-addi16sp-fail.s: Likewise.
-	testsuite/gas/riscv/c-addi4spn-fail.d: Likewise.
-	testsuite/gas/riscv/c-addi4spn-fail.l: Likewise.
-	testsuite/gas/riscv/c-addi4spn-fail.s: Likewise.
-	testsuite/gas/riscv/riscv.exp: Add new tests.
+	* testsuite/gas/riscv/c-addi16sp-fail.l: Likewise.
+	* testsuite/gas/riscv/c-addi16sp-fail.s: Likewise.
+	* testsuite/gas/riscv/c-addi4spn-fail.d: Likewise.
+	* testsuite/gas/riscv/c-addi4spn-fail.l: Likewise.
+	* testsuite/gas/riscv/c-addi4spn-fail.s: Likewise.
+	* testsuite/gas/riscv/riscv.exp: Add new tests.
 
 2017-10-24  Andrew Waterman  <andrew@sifive.com>
 
 	* testsuite/gas/riscv/c-lui-fail.d: New testcase.
-	gas/testsuite/gas/riscv/c-lui-fail.l: Likewise.
-	gas/testsuite/gas/riscv/c-lui-fail.s: Likewise.
-	gas/testsuite/gas/riscv/riscv.exp: Likewise.
+	* gas/testsuite/gas/riscv/c-lui-fail.l: Likewise.
+	* gas/testsuite/gas/riscv/c-lui-fail.s: Likewise.
+	* gas/testsuite/gas/riscv/riscv.exp: Likewise.
 
 2017-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 
diff --git a/gas/testsuite/gas/all/fill-1.d b/gas/testsuite/gas/all/fill-1.d
index da5933e..861eb0d 100644
--- a/gas/testsuite/gas/all/fill-1.d
+++ b/gas/testsuite/gas/all/fill-1.d
@@ -1,5 +1,6 @@
 #objdump: -s -j .data -j "\$DATA\$"
 #name: fill test with forward labels
+#not-target: tic4x-*-* tic54x-*-*
 
 .*: +file format .*
 
diff --git a/gas/testsuite/gas/all/fill-1.s b/gas/testsuite/gas/all/fill-1.s
index 34c52cc..d304812 100644
--- a/gas/testsuite/gas/all/fill-1.s
+++ b/gas/testsuite/gas/all/fill-1.s
@@ -1,7 +1,7 @@
 	.data
 	.dc.w 0x0a0a
-	.fill (.L2-.L1), 1, 0x0d
-.L1:
+	.fill (.L2-L1), 1, 0x0d
+L1:
 	.dc.w 0x0b0b
 .L2:
 	.dc.w 0x0c0c

-- 
Alan Modra
Australia Development Lab, IBM



More information about the Binutils mailing list