[PATCH 05/12] mips: Check UNDEFWEAK_NO_DYNAMIC_RELOC

Maciej W. Rozycki macro@mips.com
Wed Oct 18 19:30:00 GMT 2017


On Thu, 12 Oct 2017, H.J. Lu wrote:

> diff --git a/bfd/elfxx-mips.c b/bfd/elfxx-mips.c
> index 6a4d3e1a6a..23fba1bbe0 100644
> --- a/bfd/elfxx-mips.c
> +++ b/bfd/elfxx-mips.c
> @@ -5665,6 +5666,10 @@ mips_elf_calculate_relocation (bfd *abfd, bfd *input_bfd,
>        addend = 0;
>      }
>  
> +  resolved_to_zero = (h != NULL
> +		      && UNDEFWEAK_NO_DYNAMIC_RELOC (info,
> +							  &h->root));

 Gratuitous line wrapping.

 I can see you have checked it in last Sat despite Alan's request to wait 
a few days to give target maintainers an opportunity to chime in.  Please 
don't do this again.  Not everyone works weekends.

 I'll look through the change yet and see if there are any issues beyond 
mere formatting nits.

  Maciej



More information about the Binutils mailing list