[PATCH] tile: Remove the __tls_get_addr check from gc_mark_hook

Alan Modra amodra@gmail.com
Tue Oct 17 23:19:00 GMT 2017


On Tue, Oct 17, 2017 at 02:27:36PM -0700, H.J. Lu wrote:
> Reference to __tls_get_addr is created by check_relocs.  Since check_relocs
> is called after garbage collection now, the __tls_get_addr check should be
> removed from gc_mark_hook.

What happens if the only reference to __tls_get_addr is an implicit
one via TLS_GD_CALL?  Imagine a static --gc-sections link with
__tls_get_addr in its own section.  Shouldn't you instead be creating
the __tls_get_addr reference in gcc_mark_hook?

-- 
Alan Modra
Australia Development Lab, IBM



More information about the Binutils mailing list