PATCH] Properly handle note sections and segments
H.J. Lu
hjl.tools@gmail.com
Mon Nov 27 13:43:00 GMT 2017
On Sat, Nov 25, 2017 at 9:22 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Sat, Nov 25, 2017 at 6:17 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Fri, Nov 24, 2017 at 3:49 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>> gABI specifies that PT_NOTE alignment should be aligned to 4 bytes
>>> for 32-bit objects and to 8 bytes for 64-bit objects. But on Linux,
>>> .note.ABI-tag and .note.gnu.build-id notes are always aligned to 4
>>> bytes. We allow either 4 byte or 8 byte alignments.
>>>
>>> OK for master?
>>>
>>> H.J.
>>> ---
>>> * readelf.c (process_notes_at): Return FALSE if alignment of
>>> note section isn't 4 nor 8 bytes.
>>
>> This patch is incorrect. Here is the updated patch, which also fixes
>> incorrect note section alignment:
>>
>> https://sourceware.org/bugzilla/show_bug.cgi?id=22492
>>
>
> This updated patch also fixed:
>
> https://sourceware.org/bugzilla/show_bug.cgi?id=22490
>
> and dumps CORE PT_NOTE segments.
>
> OK for master?
Here is the updated patch against master branch.
--
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Properly-handle-note-sections-and-segments.patch
Type: text/x-patch
Size: 4390 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20171127/13f02ad8/attachment.bin>
More information about the Binutils
mailing list