[Translation-i18n] xtensa message pluralization

[Alan Modra]

On Fri, Nov 10, 2017 at 10:37:24AM +0000, Pedro Alves wrote:
> On 11/09/2017 07:04 PM, Bruno Haible wrote:
> > Or omit one of the plurals or even both plurals:
> >     "Mismatch for format '%s': #slots = %d, #opcodes = %d."
> > Admittedly this is not so pretty, but in tabular displays this is how
> > numbers are often printed, so that plural forms don't appear at all.
> 
> +1.  I was going to suggest this direction too.

OK, I'll go that way with following patch since I haven't heard any
preference otherwise.

	* config/tc-xtensa.c (finish_vinsn): Avoid multiple ngettext calls
	in error message.

diff --git a/gas/config/tc-xtensa.c b/gas/config/tc-xtensa.c
index 3fe85d2..a48ce1e 100644
--- a/gas/config/tc-xtensa.c
+++ b/gas/config/tc-xtensa.c
@@ -6323,6 +6323,7 @@ finish_vinsn (vliw_insn *vinsn)
 {
   IStack slotstack;
   int i;
+  int slots;
 
   if (find_vinsn_conflicts (vinsn))
     {
@@ -6334,7 +6335,8 @@ finish_vinsn (vliw_insn *vinsn)
   if (vinsn->format == XTENSA_UNDEFINED)
     vinsn->format = xg_find_narrowest_format (vinsn);
 
-  if (xtensa_format_num_slots (xtensa_default_isa, vinsn->format) > 1
+  slots = xtensa_format_num_slots (xtensa_default_isa, vinsn->format);
+  if (slots > 1
       && produce_flix == FLIX_NONE)
     {
       as_bad (_("The option \"--no-allow-flix\" prohibits multi-slot flix."));
@@ -6355,23 +6357,11 @@ finish_vinsn (vliw_insn *vinsn)
       return;
     }
 
-  if (vinsn->num_slots
-      != xtensa_format_num_slots (xtensa_default_isa, vinsn->format))
+  if (vinsn->num_slots != slots)
     {
-      char *msg;
-      int slots = xtensa_format_num_slots (xtensa_default_isa, vinsn->format);
-
-      msg = concat (ngettext ("format '%s' allows %d slot, ",
-			      "format '%s' allows %d slots, ",
-			      slots),
-		    ngettext ("but there is %d opcode",
-			      "but there are %d opcodes",
-			      vinsn->num_slots),
-		    (const char *) 0);
-
-      as_bad (msg, xtensa_format_name (xtensa_default_isa, vinsn->format),
+      as_bad (_("mismatch for format '%s': #slots = %d, #opcodes = %d"),
+	      xtensa_format_name (xtensa_default_isa, vinsn->format),
 	      slots, vinsn->num_slots);
-      free (msg);
       xg_clear_vinsn (vinsn);
       return;
     }

-- 
Alan Modra
Australia Development Lab, IBM