[PATCH] microblaze: Check for indirect and warning symbols

Michael Eager eager@eagerm.com
Wed Nov 1 15:12:00 GMT 2017


On 10/17/2017 02:26 PM, H.J. Lu wrote:
> Relocations against indirect and warning symbols should be applied to real
> symbols.
> 
> Tested with glibc build-many-glibcs.py.  OK for master?
> 
> H.J.
> 	* elf32-microblaze.c (microblaze_elf_check_relocs): Check for
> 	indirect and warning symbols.
> ---
>   bfd/ChangeLog          | 5 +++++
>   bfd/elf32-microblaze.c | 3 +++
>   2 files changed, 8 insertions(+)
> 
> diff --git a/bfd/ChangeLog b/bfd/ChangeLog
> index 2373816806..c574a9abc6 100644
> --- a/bfd/ChangeLog
> +++ b/bfd/ChangeLog
> @@ -1,3 +1,8 @@
> +2017-10-17  H.J. Lu  <hongjiu.lu@intel.com>
> +
> +	* elf32-microblaze.c (microblaze_elf_check_relocs): Check for
> +	indirect and warning symbols.
> +
>   2017-10-17  Alan Modra  <amodra@gmail.com>
>   
>   	PR 22307
> diff --git a/bfd/elf32-microblaze.c b/bfd/elf32-microblaze.c
> index 1a69b6da72..a54044fdb3 100644
> --- a/bfd/elf32-microblaze.c
> +++ b/bfd/elf32-microblaze.c
> @@ -2307,6 +2307,9 @@ microblaze_elf_check_relocs (bfd * abfd,
>         else
>   	{
>   	  h = sym_hashes [r_symndx - symtab_hdr->sh_info];
> +	  while (h->root.type == bfd_link_hash_indirect
> +		 || h->root.type == bfd_link_hash_warning)
> +	    h = (struct elf_link_hash_entry *) h->root.u.i.link;
>   
>   	  /* PR15323, ref flags aren't set for references in the same
>   	     object.  */
> 

Sorry I missed this.  OK to apply.

-- 
Michael Eager    eager@eagerm.com
1960 Park Blvd., Palo Alto, CA 94306



More information about the Binutils mailing list