[PATCH] x86: Add NOTRACK prefix support

H.J. Lu hjl.tools@gmail.com
Tue May 23 14:03:00 GMT 2017


On Tue, May 23, 2017 at 2:21 AM, Nick Clifton <nickc@redhat.com> wrote:
> Hi H.J.
>
>> For register indirect branches, NOTRACK prefix (0x3e), which is also
>> the DS segment register prefix, can be used to ignore the CET indirect
>> branch track.
>>
>> I will check it in shortly.
>
> The new test triggered some new failures for non-ELF based x86 targets:
>
>  Checking Binutils in: i386-darwin ...      GAS i386 notrackbad

Does  i386-darwin assembler really work?  I got

FAIL: i386 opcodes
FAIL: i386 opcodes (Intel disassembly)
FAIL: i386 opcodes (w/ suffix)
FAIL: i386 intel
FAIL: i386 sub
FAIL: .bundle_align_mode diagnostics
FAIL: i386 MPX
FAIL: Check -madd-bnd-prefix
FAIL: x86_64
FAIL: x86-64 (Intel mode)
FAIL: x86-64 pcrel
FAIL: x86-64 relax 1
FAIL: x86-64 immed
FAIL: x86-64 RTM insns
FAIL: x86-64 RTM insns (Intel disassembly)
FAIL: x86-64 MPX
FAIL: Check -madd-bnd-prefix (x86-64)
FAIL: gas/mach-o/dysymtab-1
FAIL: gas/mach-o/dysymtab-2
FAIL: gas/mach-o/dysymtab-3

If yes, someone should fix those.  Otherwise, we should disable i386-darwin
assembler, similar to x86_64 darwin.

>  Checking Binutils in: x86_64-pc-cygwin ... GAS i386 notrackbad, i386 x86-64-notrackbad
>  Checking Binutils in: i386-pc-go32 ...     GAS i386 notrackbad
>  Checking Binutils in: i686-pc-cygwin ...   GAS i386 notrackbad
>  Checking Binutils in: i686-pc-mingw32 ...  GAS i386 notrackbad
>  Checking Binutils in: mingw32-pe ...       GAS i386 notrackbad
>
> Would you mind updating the tests please ?
>

I checked in this patch.

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-x86-Update-notrackbad-tests-for-non-ELF-targets.patch
Type: text/x-patch
Size: 3472 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20170523/4653c8d3/attachment.bin>


More information about the Binutils mailing list