[PATCH] X86: Add SHL/SAL ModRM.reg == 6 alias

Jan Beulich JBeulich@suse.com
Tue May 23 13:55:00 GMT 2017


>>> On 23.05.17 at 15:13, <bp@suse.de> wrote:
> --- a/opcodes/i386-dis.c
> +++ b/opcodes/i386-dis.c
> @@ -3482,7 +3482,7 @@ static const struct dis386 reg_table[][8] = {
>      { "rcrA",	{ Eb, I1 }, 0 },
>      { "shlA",	{ Eb, I1 }, 0 },
>      { "shrA",	{ Eb, I1 }, 0 },
> -    { Bad_Opcode },
> +    { "shlA",	{ Eb, I1 }, 0 },
>      { "sarA",	{ Eb, I1 }, 0 },
>    },

I can certainly see why we want this (and I think I even have a
similar change sitting somewhere waiting to be submitted), but ...

> --- a/opcodes/i386-opc.tbl
> +++ b/opcodes/i386-opc.tbl

... why does the assembler need to know? When we've added
support for other aliases not so long ago, we did leave the
assembler alone.

I've also added H.J. as the x86 maintainer to Cc.

Jan



More information about the Binutils mailing list