[committed] MIPS/binutils/testsuite: Define names of temporary files

Maciej W. Rozycki macro@imgtec.com
Wed May 10 18:08:00 GMT 2017


Define `tempfile' and `copyfile' in `mips.exp' so that standalone script 
execution via `RUNTESTFLAGS=mips.exp' works rather than producing:

Running .../binutils/testsuite/binutils-all/mips/mips.exp ...
ERROR: tcl error sourcing 
.../binutils/testsuite/binutils-all/mips/mips.exp.
ERROR: can't read "tempfile": no such variable
    while executing
"binutils_assemble_flags ${srcfile} $tempfile $opts(as)"
    (procedure "run_dump_test" line 207)
    invoked from within
"run_dump_test "mips-ase-1""
    invoked from within
"if [is_elf_format] {
    run_dump_test "mips-ase-1"
    run_dump_test "mips-ase-2"
    run_dump_test "mips-ase-3"
    run_dump_test "mixed-mips16"
   ..."
    (file ".../binutils/testsuite/binutils-all/mips/mips.exp" line 22)
    invoked from within
"source .../binutils/testsuite/binutils-all/mips/mips.exp"
    ("uplevel" body line 1)
    invoked from within
"uplevel #0 source .../binutils/testsuite/binutils-all/mips/mips.exp"
    invoked from within
"catch "uplevel #0 source $test_file_name""
testcase .../binutils/testsuite/binutils-all/mips/mips.exp completed in 0 seconds

	binutils/
	* testsuite/binutils-all/mips/mips.exp: Define `tempfile' and 
	`copyfile' variables.
---
binutils-mips-binutils-test-tempfile.diff
Index: binutils/binutils/testsuite/binutils-all/mips/mips.exp
===================================================================
--- binutils.orig/binutils/testsuite/binutils-all/mips/mips.exp	2017-05-06 17:06:00.000000000 +0100
+++ binutils/binutils/testsuite/binutils-all/mips/mips.exp	2017-05-06 18:37:19.283026928 +0100
@@ -19,6 +19,14 @@ if ![istarget mips*-*-*] {
     return
 }
 
+if [is_remote host] {
+    set tempfile [remote_download host tmpdir/bintest.o]
+    set copyfile copy
+} else {
+    set tempfile tmpdir/bintest.o
+    set copyfile tmpdir/copy
+}
+
 if [is_elf_format] {
     run_dump_test "mips-ase-1"
     run_dump_test "mips-ase-2"



More information about the Binutils mailing list