[PATCH] [ARC] Object attributes.

[Nick Clifton]

Hi Claudiu,

  Thanks for fixing the test failure.  Unfortunately I failed to actually look
  at the code in the patch whilst I was testing it, so I missed a few things.
  Specifically:

> +/* Allocate and concatenate two strings.  s1 can be NULL but not> +   s2.  s1 pointer is freed at end of this procedure.  */> +> +static char *> +arc_stralloc (char * s1, const char * s2)
  Couldn't you make use of libiberty's concat() function here ?

> +	      /* We cannot mix code for different CPUs.  */
> +	      _bfd_error_handler
> +		(_("error: %B: unable to merge CPU base attributes "
> +		   "with %B."),
> +		 obfd, ibfd);

  It would probably be helpful to the user if the error message said
  exactly which two CPU types are involved here.

  (Similarly for other error messages in this function).

Cheers
  Nick