pr21665

[Nick Clifton]

Hi Alan,

> Nick, your commit cfd14a500 for pr21665 blows up mmo, and if there
> were tests for it, probably other encoded formats like ihex and srec.
> 
> mmix  +FAIL: ld-mmix/getaa12b

You are right.  Sorry for not catching this myself when I originally created
the patch.

I am going to check in the patch below as a workaround for this problem.  It
fixes the MMIX failures and still catches the problematic binary in PR 21665,
but it also places an arbitrary upper limit of 2Gb on the size of a section 
that can be disassembled.  I think that this is a reasonable limit for now,
although if not, I am sure that someone will complain.  (Unless you happen
to know of a way to determine beforehand whether a call to xmalloc will fail ?)

Cheers
  Nick

binutils/ChangeLog
2017-06-30  Nick Clifton  <nickc@redhat.com>

	PR binutils/21665
	* objdump.c (disassemble_section): Move check for an overlarge
	section to just before the allocation of memory.  Do not check
	section size against file size, but instead use an arbitrary 2Gb
	limit.  Issue a warning message if the section is too big.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pr21665.patch
Type: text/x-patch
Size: 1809 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20170630/bd809a29/attachment.bin>