[PATCH 1/9] [ARC] Avoid creating dynamic relocs when static linked is requested.
Nick Clifton
nickc@redhat.com
Wed Jun 7 12:23:00 GMT 2017
Hi Cupertino,
> If one invokes ADD_RELA when no dynamic sections get created, it would
> segmentation fault.
> However, invocations to this macro are being done eagerly and that is
> the reason for the simple condition fix.
>
> Honestly, thinking about it now I do not find a use case where it would
> be helpful to return an error message, but I can be wrong. :-(
> Do you have use case in mind?
None - I was just checking. Plus I like to be paranoid when programming
and it seemed to me that this might be a case where an error message would
have been helpful. But I understand your argument that the reloc generation
is done eagerly, so I have no more objections to the patch.
Approved - please apply.
Cheers
Nick
More information about the Binutils
mailing list