[COMMITTED][AArch64] Fix the bit pattern order in the comments in auto-generated file

Jiong Wang jiong.wang@foss.arm.com
Mon Jul 24 14:12:00 GMT 2017


Laurent Desnogues reported a AArch64 GAS assembler issue in the auto-generated
file.
                                                                                                           
The bit pattern comment in "aarch64_opcode_lookup_1" is reversed.
                                                                                                           
This patch fixed this, the change in the comment is something like the
following:

@@ -38,7 +38,7 @@ aarch64_opcode_lookup_1 (uint32_t word)
                      {
                        /* 33222222222211111111110000000000
                           10987654321098765432109876543210
-                         xxxxxxxxxxxxxxxxxxxxxxxx0000xxx0
+                         0xxx0000xxxxxxxxxxxxxxxxxxxxxxxx
                           adr.  */

The generated file is not included in the attached patch as it boost the patch
size.

Build under --enable-maintainer-mode OK. Eyeballed to make sure there is only
comments change in aarch64-dis-2.c, also a quick cross as/ld check OK.
                                                                                                           
opcodes/
2017-07-24  Laurent Desnogues <laurent.desnogues@arm.com>
             Jiong Wang  <jiong.wang@arm.com>
                                                                                                           
         * aarch64-gen.c (print_decision_tree_1): Reverse the index of PATTERN to
         correct the print.
         * aarch64-dis-2.c: Regenerated.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1.patch
Type: text/x-patch
Size: 1434 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20170724/34a58a97/attachment.bin>


More information about the Binutils mailing list