[PATCH] aarch64: ld: fix relaxations for ilp32 mode

Jiong Wang jiong.wang@foss.arm.com
Thu Jan 19 16:16:00 GMT 2017



On 19/01/17 16:08, Yury Norov wrote:
> On Thu, Jan 19, 2017 at 03:47:20PM +0000, Jiong Wang wrote:
>> And the following coding style nits, otherwise looks good to me.
>>
>> Yury Norov writes:
>>
>>> +#else /*ARCH_SIZE == 32 */
>> /* ARCH_SIZE == 32 */
>>
>>> +	  bfd_putl32 (add_R0_R0 | (TCB_SIZE << 10), contents + rel->r_offset + 4);
>> Over 80 columns.
>>
>>> +	  bfd_putl32 (add_R0_R0 | (TCB_SIZE << 10), contents + rel->r_offset + 0);
>> Likewise.
>>
>> -- 
>> Regards,
>> Jiong
> Does it mean I can push it after addressing your and Andreas'
> comments, or I should wait for other approves?

You need to wait either AArch64 maintainer's approval (Richard Earnshaw 
or Marcus Shawcroft) or head maintainer's approval (Nick)

See section "Maintainers" in binutils/MAINTAINERS,  it describes the policy.


Regards,
Jiong



More information about the Binutils mailing list