[PATCH][gold] PR 21054: Fix GOT when global symbols are forced to local visibility

Aurelien Jarno aurelien@aurel32.net
Thu Jan 19 08:35:00 GMT 2017


On 2017-01-18 18:23, Vladimir Radosavljevic wrote:
> Don't add global symbol that requires GOT entry to the dynamic symbol table if it is forced to local visibility.
> 
> Regards,
> Vladimir
> 
> ChangeLog -
> 
> gold/
> 	PR gold/21054
> 	* mips.cc (Mips_got_info::record_global_got_symbol): Don't add symbol
> 	to the dynamic symbol table if it is forced to local visibility.
> 	(Target_mips::do_finalize_sections): Don't add __RLD_MAP symbol to the
> 	dynamic symbol table if it is forced to local visibility.

Thanks for the quick patch. I confirm it fixes the original issue, that
is systemd crashing when built with gold. Also note that the problem
also affects the 2.28 branch, so the patch would have to be backported
after commited to master.

Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net



More information about the Binutils mailing list