[ld, testsuite] Relax the expectation pattern for several plugin-* tests

Jiong Wang jiong.wang@foss.arm.com
Mon Feb 13 16:03:00 GMT 2017


>>> hook called: all symbols read.
>>> Input: /work/fsf-trunk-3/src/binutils-gdb/ld/testsuite/ld-plugin/func.c
>>> (/work/fsf-trunk-3/src/binutils-gdb/ld/testsuite/ld-plugin/func.c)
>>> Sym: 'func' Resolution: LDPR_PREVAILING_DEF
>>> Sym: '_func' Resolution: LDPR_PREVAILING_DEF_IRONLY
>>> /work/fsf-trunk-3/build-arm-none-eabi/obj/binutils/ld/ld-new:
>>> /work/fsf-trunk-3/src/binutils-gdb/ld/testsuite/ld-plugin/func.c (symbol
>>> from plugin)(func): warning: interworking not enabled.
>>>   first occurrence:
>>> /work/fsf-trunk-3/build-arm-none-eabi/obj/binutils/ld/tmpdir/main.o: Thumb
>>> call to ARM
>>
>> I think those failures are caused by those extra messages.
>> I am not familiar with ARM linker.  I can skip those tests
>> for ARM.
>
> It looks like an ARM linker bug.  ARM linker shouldn't complain
> anything on input BFDs with BFD_PLUGIN since it is a dummy
> input file.

Or can we simply relax the testcase expectation result a little bit while
we still keeps those essential outputs that we want to catch?

Is this patch OK for master?

IMHO, keeping the warning might be better than silently accepting it.  As the
dummy input file really doesn't have proper elf header flags.  I am not sure
if relax the checking on BFD_PLUGIN will cause hiding silent issue once there
is future change on BFD_PLUGIN.

ld/
2017-02-10  Jiong Wang  <jiong.wang@arm.com>

         * testsuite/ld-plugin/plugin-15.d: Relax the match pattern.
         * testsuite/ld-plugin/plugin-16.d: Likewise.
         * testsuite/ld-plugin/plugin-20.d: Likewise.
         * testsuite/ld-plugin/plugin-21.d: Likewise.
         * testsuite/ld-plugin/plugin-22.d: Likewise.
         * testsuite/ld-plugin/plugin-23.d: Likewise.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-test.patch
Type: text/x-diff
Size: 3419 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20170213/899ac122/attachment.bin>


More information about the Binutils mailing list