[PATCH] Fix internal error on unterminated --start-lib option.

Benjamin Peterson bp@benjamin.pe
Fri Dec 1 21:46:00 GMT 2017



On Fri, Dec 1, 2017, at 13:04, Cary Coutant wrote:
> >         * Makefile.in: Regenerate.
> 
> No need to regenerate this -- automake keeps generating this useless
> diff.

Ah, that's unfortunate.

> 
> >         * gold.cc (queue_initial_tasks) Check for number of real input files.
> >         * options.cc (Command_line::process) Check for unterminated --start-lib
> >         options.
> >         * testsuite/Makefile.am: Add new test script.
> >         * testsuite/Makefile.in: Regenerate.
> >         * testsuite/check_empty_command_lines.sh: New test script.
> 
> This is OK. I've committed the patch (without Makefile.in) on your
> behalf.

Thank you!

While I have you, can I ask how the gold maintainers run the test suite?
Running x86_64, I noticed that several tests are broken on master. The
incremental linking ones look like legitimate failures.



More information about the Binutils mailing list