[PATCH] PR ld/21382: Handle symbol defined in IR and referenced in DSO

Alan Modra amodra@gmail.com
Wed Apr 19 00:49:00 GMT 2017


On Fri, Apr 14, 2017 at 08:44:56AM -0700, H.J. Lu wrote:

> +++ b/bfd/elflink.c
> +	      /* Preserve re_def_dynamic_ref so that this symbol will

Comment typo.

> +++ b/include/bfdlink.h
> +  /* Symbol is defined in an IR object and referenced in a dynamic
> +     object.  */
> +  unsigned int ir_def_dynamic_ref : 1;

The comment here isn't completely true.  The flag will only be set if
the dynamic object is linked *after* the IR object, won't it?  I think
it is worth stating that, or fixing your plugin_notice change to also
cover the case where the IR object is linked after a dynamic object.

-- 
Alan Modra
Australia Development Lab, IBM



More information about the Binutils mailing list