[GDB] Use AC_CHECK_SIZEOF to test for PRFPREGSET_T_BROKEN

Matthew Wahab matthew.wahab@foss.arm.com
Wed Sep 28 07:28:00 GMT 2016


On 28/09/16 00:41, Yao Qi wrote:
> On Mon, Sep 26, 2016 at 3:17 PM, Matthew Wahab
> <matthew.wahab@foss.arm.com> wrote:
>> Hello,
>>
>> If the GDB configure script finds sys/procfs.h and the prfpregset_t
>> type, it checks whether prfpregset_t is usable, setting
>> PRFPREGSET_T_BROKEN if so. It does this using AC_TRY_RUN to test the
>> value of sizeof(prfregset_t). This doesn't work for cross-compiled
>> builds so for those PRFPREGSET_T_BROKEN is always set.
>>
>> This patch replaces the use of AC_TRY_RUN with a test that uses
>> AC_CHECK_SIZEOF to decide whether to set PRFPREGSET_T_BROKEN. This can
>> be run for cross-compiled builds.
>>
>> Tested by cross-compiling for aarch64-none-linux-gnu and recent
>> glibc and by building with the logic inverted, to check the conditional was
>> correctly executing. Also by building for native x86_64-none-linux-gnu.
>>
>> Ok for trunk?
>
> Hi Matthew,
> Thanks for the follow-up patch.  The patch should be sent gdb-patches@ mailing
> list.
>

Sorry about that. Now done.
Matthew



More information about the Binutils mailing list