[PATCH 4/6] RISC-V opcodes

Nick Clifton nickc@redhat.com
Fri Oct 14 14:40:00 GMT 2016


Hi Andrew,

> +++ b/include/opcode/riscv-opc.h
> @@ -0,0 +1,1160 @@
> +/* Automatically generated by parse-opcodes */

If this file is generated by a tool, then that tool (and input files it
requires) should be part of the submission too.  Either that, or else
these generated files should be changed to be considered to be the 
originals, and no generator mentioned or needed.

The actual patch itself looks reasonably to me, although I have not
yet tested it in a real build.  (I am waiting until all of the patches
have been reviewed and, if necessary, updated).

Cheers
  Nick



More information about the Binutils mailing list