[PATCH v2][gold] Implement --build-id=uuid on MinGW/MSYS2.

Igor Kudrin ikudrin@accesssoftek.com
Wed Nov 9 13:16:00 GMT 2016


Ping.
________________________________________
From: binutils-owner@sourceware.org <binutils-owner@sourceware.org> on behalf of Igor Kudrin <ikudrin@accesssoftek.com>
Sent: Friday, October 21, 2016 11:58 AM
To: Cary Coutant
Cc: binutils@sourceware.org
Subject: [PATCH v2][gold] Implement --build-id=uuid on MinGW/MSYS2.

Hi Cary,

Thank you for the comments. In this version, I've replaced C-style cast
to reinterpret_cast. Hope it's OK now.

Best regards,
Igor Kudrin

---
gold/ChangeLog

        * layout.cc: Changes for MinGW32:
        Include windows.h and rpcdce.h.
        (Layout::create_build_id): Generate uuid using UuidCreate().

________________________________________
From: Cary Coutant <ccoutant@gmail.com>
Sent: Friday, October 21, 2016 2:19 AM
To: Igor Kudrin
Cc: binutils@sourceware.org
Subject: Re: [PATCH][gold] Implement --build-id=uuid on MinGW/MSYS2.

> gold/ChangeLog
>
>         * layout.cc: Changes for MinGW32:
>         Include windows.h and rpcdce.h.
>         (Layout::create_build_id): Use UuidCreate() to generate uuid.

+  UuidCreateFn uuid_create =
+      (UuidCreateFn)GetProcAddress(rpc_library, "UuidCreate");

Please use a C++ style case here. With that change, the patch looks good.

-cary



More information about the Binutils mailing list