[PATCH v2 2/7] gas/arc: Replace short_insn flag with insn length field

Nick Clifton nickc@redhat.com
Thu Nov 3 16:29:00 GMT 2016


Hi Graham,

> gas/ChangeLog:
> 
> 	* config/tc-arc.c (struct arc_insn): Replace short_insn flag with
> 	len field.
> 	(apply_fixups): Update to use len field.
> 	(emit_insn0): Simplify code, making use of len field.
> 	(md_convert_frag): Update to use len field.
> 	(assemble_insn): Update to use len field.

Approved - please apply.  Although I do have one small question:

>    long limm;
> -  bfd_boolean short_insn; /* Boolean value: TRUE if current insn is
> -			     short.  */
> +  int len;                /* Length of instruction in bytes.  */

Can the length be negative ?  If not then maybe "unsigned int" would be more appropriate.

Cheers
  Nick



More information about the Binutils mailing list