[PATCH][MIPS] Add support for P6600

Robert Suchanek Robert.Suchanek@imgtec.com
Fri May 20 14:32:00 GMT 2016


Hi Maciej,

> Hi Robert,
> 
>  Apologies to have missed your patch.  This is OK with the two formatting
> nits below addressed, no need to repost.  Also, since you'll be committing
> on behalf of someone else, please ensure the right authorship attribution,
> e.g. `git commit --author=...' -- apologies if you find this obvious.

Thanks for the reminder as I commit more patches to GCC rather than Binutils.

> 
> > gas/ChangeLog:
> >
> > 2016-05-13  Matthew Fortune  <matthew.fortune@imgtec.com>
> >
> > 	* config/tc-mips.c (mips_cpu_info_table): Update comment. Add
> 
>  Two spaces after a full stop please.

Fixed.

> 
> > diff --git a/gas/config/tc-mips.c b/gas/config/tc-mips.c
> > index b538ff0..f424307 100644
> > --- a/gas/config/tc-mips.c
> > +++ b/gas/config/tc-mips.c
> > @@ -18745,8 +18745,9 @@ static const struct mips_cpu_info
> mips_cpu_info_table[] =
> >       MIPS64R2 rather than MIPS64.  */
> >    { "xlp",	      0, 0,			ISA_MIPS64R2, CPU_XLR },
> >
> > -  /* i6400.  */
> > +  /* MIPS 64 Release 6  */
> 
>  This is not a sentence, so just a single space at the end please, just as
> with the remaining like comments across this struct.

Got it.

The patch is now committed.

Regards,
Robert



More information about the Binutils mailing list