[PATCH 2/2] LD/testsuite: Expand STB_GNU_UNIQUE test coverage

Matthew Fortune Matthew.Fortune@imgtec.com
Wed May 4 08:43:00 GMT 2016


Maciej Rozycki <Maciej.Rozycki@imgtec.com> writes:
> +# Exclude some more targets; feel free to include your favorite one #
> +if you like.  The MSP430 and Visium targets set the ELF header's #
> +OSABI field to ELFOSABI_STANDALONE and cannot support STB_GNU_UNIQUE.
> +if { !([istarget "*-*-elf*"]
> +       && ![istarget "msp430-*-*"]
> +       && ![istarget "visium-*-*"])
> +     && ![istarget *-*-nacl*]
> +     && ![istarget *-*-linux*]
> +     && ![istarget *-*-gnu*] } {
>      verbose "UNIQUE tests not run - target does not support UNIQUE"
>      return
>  }

Quite subjective but I found the new condition hard to read; the
following seems to match the comment more naturally to me:

if { (![istarget "*-*-elf*"]
      || [istarget "msp430-*-*"]
      || [istarget "visium-*-*"])
     && ![istarget *-*-nacl*]
     && ![istarget *-*-linux*]
     && ![istarget *-*-gnu*] } {

Matthew



More information about the Binutils mailing list