[patch, testsuite] Use Alternative version of lns-common-1 test for AVR port

Nick Clifton nickc@redhat.com
Tue May 3 10:00:00 GMT 2016


Hi Sivanupandi,

> AVR target doesn't disable/ undef DWARF2_USE_FIXED_ADVANCE_PC; It generates
> DW_LNS_fixed_advance_pc opcodes for line number information by default. So,
> AVR target shall expect alternate output file for lns-common-1 test (lns.exp).

Technically speaking the AVR target does not need to disable DWARF2_USE_FIXED_ADVANCED_PC
since this is defined by default in dwarf2dbg.c.  The definition there uses the
value of the linkrelax global variable, and this *is* set in tc-avr.c.  The
default however is to disable linkrelax, so your patch is correct - it matches
the default behaviour of the AVR assembler.

> gas/ChangeLog
> 2016-04-29  Pitchumani Sivanupandi  <pitchumani.s@atmel.com>
> 
> 	* testsuite/gas/lns/lns.exp: Add avr to list of targets using
> 	DW_LNS_fixed_advance_pc.

Approved and applied.

Cheers
  Nick



More information about the Binutils mailing list