[PATCH] replace some raw xmalloc / xrealloc with the XNEW* macros
Trevor Saunders
tbsaunde@tbsaunde.org
Tue Mar 22 21:54:00 GMT 2016
On Tue, Mar 22, 2016 at 04:43:55PM +0000, Nick Clifton wrote:
> Hi Trevor,
>
> > gas/ChangeLog:
> > 2016-03-19 Trevor Saunders <tbsaunde+binutils@tbsaunde.org>
> >
> > * listing.c (listing_message): Use XNEW style allocation macros.
> > * read.c (read_a_source_file): Likewise.
> > (read_symbol_name): Likewise.
> > (s_mri_common): Likewise.
> > (assign_symbol): Likewise.
> > (s_reloc): Likewise.
> > (emit_expr_with_reloc): Likewise.
> > (s_incbin): Likewise.
> > (s_include): Likewise.
> > * sb.c (sb_build): Likewise.
> > (sb_check): Likewise.
>
> Approved - please apply.
>
> Note - I find it irksome that the type has to be specified in these
> macros, rather than extract from the variable being (re)allocated,
> but I could not think of any clean, non-GCC specific, way of
> achieving this. So please go ahead with the patch as is.
yeah, my thinking was mostly that its no worse than T *foo = (T *)
xmalloc ();
Trev
>
> Cheers
> Nick
>
>
More information about the Binutils
mailing list