Commit: Use of alloca considered dangerous

Alan Modra amodra@gmail.com
Tue Mar 22 03:57:00 GMT 2016


On Mon, Mar 21, 2016 at 11:01:36AM -0700, H.J. Lu wrote:
> It caused:
> 
> https://sourceware.org/bugzilla/show_bug.cgi?id=19851

Let's avoid the warning then.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 43c9c28..ffafbf6 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2016-03-22  Alan Modra  <amodra@gmail.com>
+
+	PR 19851
+	* plugin.c (try_load_plugin): Avoid -Wstack-usage warning.
+
 2016-03-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 
 	* archures.c (bfd_mach_arc_nps400): Define.
diff --git a/bfd/plugin.c b/bfd/plugin.c
index 82a87d6..f57833c 100644
--- a/bfd/plugin.c
+++ b/bfd/plugin.c
@@ -206,8 +206,7 @@ static int
 try_load_plugin (const char *pname, bfd *abfd, int *has_plugin_p)
 {
   void *plugin_handle;
-  int tv_size = 4;
-  struct ld_plugin_tv tv[tv_size];
+  struct ld_plugin_tv tv[4];
   int i;
   ld_plugin_onload onload;
   enum ld_plugin_status status;

-- 
Alan Modra
Australia Development Lab, IBM



More information about the Binutils mailing list