PING: Re: [PATCHv2 0/2] Add initial arc nps400 support
Nick Clifton
nickc@redhat.com
Tue Mar 15 11:14:00 GMT 2016
Hi Andrew,
> PING! I've had some great feedback from Claudiu, but I'm still hoping
> for a global maintainer to cast an eye over this too please.
Oops - sorry - dropped the ball on this one.
The patches (1 and 2) both look fine to me, apart from one very small issue:
The new assembler test control files (gas/testsuite/gas/arc/nps400-0.d and
gas/testsuite/gas/arc/nps400-1.d) both restrict the test to:
#target: arc*-mellanox-*
What is "mellanox" and why is it included in the target string ? The name
is not present in the gas/configure.tgt or bfd/config.bfd files, so I am
assuming that it is a manufacturer name and not an OS name. If so then its
presence in these tests will stop them from being run with toolchains
configured with, for example, --target=arc-elf. (This matters to me, since
that is one of the configurations I use in my daily regression testing).
Cheers
Nick
More information about the Binutils
mailing list