[ld/testsuite] Skip "Mixing PIC and non-PIC" testcase on ARM/AArch64 if when no -fpie or -fPIE

Jiong Wang jiong.wang@foss.arm.com
Wed Mar 2 16:08:00 GMT 2016


>>> Have you looked at the testcase I added? Are there anything
>>> which are target specific?
>>
>> I do have looked at the testcase, they do be purely C code.
>>
>> If the convention of generic is syntax generic instead of both syntax and
>> sematics, I don't have further comment on this.
>>
>> Anyway, attached patch skips the non-pie version "Mixing PIC and non-PIC"
>> testcase.
>>
>> Not sure if it's trivial enough to qualify obvious, so OK for master branch?
>>
>> 2016-03-02  Jiong Wang  <jiong.wang@arm.com>
>>
>> ld/testsuite/
>>
>>    * ld-elf/shared.exp (mix_pic_and_non_pic): Only run on ARM and AArch64
>>      when -fPIE or -fpie specified.
> That is wrong.  If you don't want to see FAIL, you can skip the whole.
> mix_pic_and_non_pic.  Please don't modify mix_pic_and_non_pic.

Then, how about the updated version?

2016-03-02  Jiong Wang  <jiong.wang@arm.com>

ld/testsuite/

    * ld-elf/shared.exp: Skip "Mixing PIC and non-PIC" on ARM and AArch64
    if -fpie or -fPIE not specified.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: k.patch
Type: text/x-patch
Size: 409 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20160302/5db76781/attachment.bin>


More information about the Binutils mailing list