[PATCH] PR ld/19636: [x86] Resolve undefweak and defined symbols in executable

Ramana Radhakrishnan ramana.gcc@googlemail.com
Wed Mar 2 13:34:00 GMT 2016


>
> Well, then why you put it under generic directory? and without restricting
> it
> on x86?

Hang on Jiong - seeing the failure on other targets is fine -
technically other targets need to know if they are broken or not, the
best way of getting attention is a FAIL.

regards
Ramana

>
> IMO, the support of weak symbol under various rare and complex scenarios are
> very
> target specific, thus I'd either move this testcase under x86 directory or
> put it under
> generic directory but enabling it on x86 only initially.  If other targets
> want and start
> to support similar features like x86 on weak symbol, then they can be
> enabled seperately.
> This looks to me is a more clean & acceptable way to other targets.
>
> Thanks.
>
> Regards,
> Jiong



More information about the Binutils mailing list