[PATCH] xtensa: prototype xtensa_make_property_section in elf/xtensa.h

tbsaunde+binutils@tbsaunde.org tbsaunde+binutils@tbsaunde.org
Thu Jun 23 14:47:00 GMT 2016


From: Trevor Saunders <tbsaunde+binutils@tbsaunde.org>

Hi,

There's no reason to have multiple prototypes for the same function.

built and regtested xtensa-elf, ok?

Trev

include/ChangeLog:

2016-06-23  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>

	* elf/xtensa.h (xtensa_make_property_section): New prototype.

gas/ChangeLog:

2016-06-23  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>

	* config/tc-xtensa.c (xtensa_make_property_section): Remove prototype.

bfd/ChangeLog:

2016-06-23  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>

	* elf32-xtensa.c (xtensa_make_property_section): Remove prototype.
---
 bfd/elf32-xtensa.c     | 1 -
 gas/config/tc-xtensa.c | 4 ----
 include/elf/xtensa.h   | 2 ++
 3 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/bfd/elf32-xtensa.c b/bfd/elf32-xtensa.c
index af9618d..41506f4 100644
--- a/bfd/elf32-xtensa.c
+++ b/bfd/elf32-xtensa.c
@@ -110,7 +110,6 @@ static bfd_boolean xtensa_is_proptable_section (asection *);
 static int internal_reloc_compare (const void *, const void *);
 static int internal_reloc_matches (const void *, const void *);
 static asection *xtensa_get_property_section (asection *, const char *);
-extern asection *xtensa_make_property_section (asection *, const char *);
 static flagword xtensa_get_property_predef_flags (asection *);
 
 /* Other functions called directly by the linker.  */
diff --git a/gas/config/tc-xtensa.c b/gas/config/tc-xtensa.c
index d2a3567..5840135 100644
--- a/gas/config/tc-xtensa.c
+++ b/gas/config/tc-xtensa.c
@@ -526,10 +526,6 @@ static void xtensa_switch_section_emit_state (emit_state *, segT, subsegT);
 static void xtensa_restore_emit_state (emit_state *);
 static segT cache_literal_section (bfd_boolean);
 
-/* Import from elf32-xtensa.c in BFD library.  */
-
-extern asection *xtensa_make_property_section (asection *, const char *);
-
 /* op_placement_info functions.  */
 
 static void init_op_placement_info_table (void);
diff --git a/include/elf/xtensa.h b/include/elf/xtensa.h
index ca178f5..be55cd7 100644
--- a/include/elf/xtensa.h
+++ b/include/elf/xtensa.h
@@ -209,6 +209,8 @@ typedef struct property_table_entry_t
 
 #define XTENSA_PROP_INSN_ABSLIT        0x00020000
 
+extern asection *xtensa_make_property_section (asection *, const char *);
+
 #ifdef __cplusplus
 }
 #endif
-- 
2.8.1



More information about the Binutils mailing list