add vulcan support to gas

Virendra Pathak virendra.pathak@broadcom.com
Wed Jun 8 05:36:00 GMT 2016


Hi Marcus,

1) I have attached the binutils patch in the first mail
(https://sourceware.org/ml/binutils/2016-06/msg00064.html)
Attaching in this mail too . Corresponding GCC patch is here
https://gcc.gnu.org/ml/gcc-patches/2016-06/msg00541.html

2) Added the author entry in the ChangeLog

gas/ChangeLog:
Virendra Pathak (virendra.pathak@broadcom.com)
* config/tc-aarch64.c (aarch64_cpus): Add vulcan.
* doc/c-aarch64.texi : Document that vulcan is a valid processor name
with regards,
Virendra Pathak


On Wed, Jun 8, 2016 at 4:58 AM, Marcus Shawcroft
<marcus.shawcroft@gmail.com> wrote:
> On 7 June 2016 at 14:10, Syed Faisal Akber <faisal@akber.net> wrote:
>>
>>
>> Sent from my BlackBerry 10 smartphone.
>>   Original Message
>> From: Virendra Pathak
>> Sent: Tuesday, June 7, 2016 04:56
>> To: binutils@sourceware.org
>> Cc: Virendra Kumar Pathak; nickc@redhat.com
>> Subject: add vulcan support to gas
>>
>> Hi binutils group,
>>
>> We have a patch for adding -mcpu=vulcan support to gas.
>> Broadcom's Vulcan is a armv8-a aarch64 served based processor.
>> We have also got company wide FSF agreement for contributing to
>> binutils project.
>>
>> However, recently I read on this group that now gcc does not pass
>> -mcpu flag to binutils. GCC now passes -march flag to binutils.
>> I verified this by compiling a simple hello world inspecting the
>> assembler flags.
>> [https://gcc.gnu.org/ml/gcc-patches/2015-08/msg01106.html]
>> [https://sourceware.org/ml/binutils/2015-08/msg00169.html]
>>
>> Keeping this in mind, do we still need to add -mcpu=vulcan support to
>> gas, given that many armv8-a vendors have done it?
>> Kindly guide me on this.
>>
>> Please also find the patch (-mcpu=vulcan) attached with this mail for review.
>
> Hi, The patch appears to be missing ?
>
>
>> Tested the patch with aarch64-linux-gnu cross build,
>> aarch64-unknown-linux-gnu native build and make check (ld,gdb,gas,binutils).
>> Also verified the new option via command line.
>>
>> Thanks for your time.
>>
>>
>> gas/ChangeLog:
>> * config/tc-aarch64.c (aarch64_cpus): Add vulcan.
>> * doc/c-aarch64.texi : Document that vulcan is a valid processor name
>
> The proposed changelog entry is missing the author line.
>
> Thanks
> /Marcus
>
>>
>>
>> with regards,
>> Virendra Pathak
-------------- next part --------------
From 1eff9ab01a0bb18261a1f3255afc44b52217a6d0 Mon Sep 17 00:00:00 2001
From: Virendra Pathak <virendra.pathak@broadcom.com>
Date: Mon, 30 May 2016 04:21:50 -0700
Subject: [PATCH] aarch64: add vulcan support to gas

---
 gas/config/tc-aarch64.c | 3 +++
 gas/doc/c-aarch64.texi  | 1 +
 2 files changed, 4 insertions(+)

diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
index 415663b..21fe4b5 100644
--- a/gas/config/tc-aarch64.c
+++ b/gas/config/tc-aarch64.c
@@ -7762,6 +7762,9 @@ static const struct aarch64_cpu_option_table aarch64_cpus[] = {
   {"qdf24xx", AARCH64_FEATURE (AARCH64_ARCH_V8,
 			       AARCH64_FEATURE_CRC | AARCH64_FEATURE_CRYPTO),
    "Qualcomm QDF24XX"},
+  {"vulcan", AARCH64_FEATURE (AARCH64_ARCH_V8,
+                              AARCH64_FEATURE_CRC | AARCH64_FEATURE_CRYPTO),
+  "Broadcom Vulcan"},
   {"thunderx", AARCH64_FEATURE (AARCH64_ARCH_V8,
 				AARCH64_FEATURE_CRC | AARCH64_FEATURE_CRYPTO),
    "Cavium ThunderX"},
diff --git a/gas/doc/c-aarch64.texi b/gas/doc/c-aarch64.texi
index a193908..0156012 100644
--- a/gas/doc/c-aarch64.texi
+++ b/gas/doc/c-aarch64.texi
@@ -61,6 +61,7 @@ on the target processor.  The following processor names are recognized:
 @code{cortex-a72},
 @code{exynos-m1},
 @code{qdf24xx},
+@code{vulcan},
 @code{thunderx},
 @code{xgene1}
 and
-- 
2.1.0



More information about the Binutils mailing list