[PATCH, binutils] Fix implib test failures

[Thomas Preudhomme]

On Tuesday 19 July 2016 16:34:26 Nick Clifton wrote:
> Hi Thomas,
> 
> >> +setup_xfail "am33lin-*-*" "d30v-*-*" "dlx-*-*" "i960-*-*" "m68hc1x-*-*"
> >> +setup_xfail "m88k-*-*" "pj-*-*" "score7-*-*" "sh64-*-*" "vxworks-*-*"
> >> 
> >>   There are other score targets apart from score7.  score-elf and
> >>   score3-elf
> >> 
> >> for example.  How about score*-*-* instead ?
> > 
> > I did not know how to get the affected triplet. All I got was a list of
> > bfd/elf*-*.c that do not define elf_backend_relocate_section. I use the
> > the
> > value for the second * as the machine bit of the triplet.
> 
> Right, and you skipped the elfxx-*.c targets that matched this test as well,
> right.  I think that the test should be any elf*.c file that does not
> define elf_backend_relocate section or reference bfd_elf_final_link and
> which *does* include elfNN-target.h - ie one which creates an
> elf_backend_data structure.
> 
> So I think that you can skip vxworks entirely here, since elf-vxworks.c is
> just a support file for vxworks targets, and not a cpu type by itself.
> (Similarly for am33lin which just #include's elf-m10300.c which then does
> define elf_backend_relocate_section.
> 
> > Are there other
> > triplet in this list you see as not being inclusive enough?
> 
> Nope.
> 
> > How can I find the
> > list of triplet corresponding to a given bfd file?
> 
> Look in bfd/configure.ac.  Starting at around line 382 there is a list
> of targets and the target specific files that they need.  A little bit
> of searching can tell you which files are used by which targets.

Alright, I removed vxworks and am33lin and use score*-*-* as suggested. I also 
removed m68hc1x (either elf32-m68hc11.c or bfd/elf32-m68hc12.c are used and 
they define elf_backend_relocate_section). I'm still puzzled at score since I 
only see one line for it which does not suggest me that there is several value 
possible. I'm also unsure about sh64 whose sh64_elf32_vec variant does not 
define elf_backend_relocate_section.

Alan, you seem to already have an automated build setup with all possible 
targets. Would you mind letting me know if the attached updated patch fixes 
everything?

Best regards,

Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_implib_test_failures.patch
Type: text/x-patch
Size: 4438 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20160720/bc079da3/attachment.bin>