[PATCH] Fix grammar in bfd warning message
Phil Blundell
pb@pbcl.net
Tue Jul 12 10:45:00 GMT 2016
On Tue, 2016-07-12 at 12:02 +0200, Douglas B Rupp wrote:
> Please review and apply attached if you please.
> I don't have write privileges.
> -Â Â Â Â Â Â Â Â Â Â Â Â Â (_("Warning: Writing section `%s' to huge (ie negative)
file offset 0x%lx."),
> +Â Â Â Â Â Â Â Â Â Â Â Â Â (_("Warning: Writing section `%s' too huge (ie
negative) file offset 0x%lx."),
I don't think this change is an improvement. Â In the original phrasing
"to" was intended to be a preposition: it's complaining that it is
writing a section "to" a location in the file whose offset is so large
that it doesn't fit in a signed int. Â With your change the sentence no
longer has a preposition which breaks the grammar.Â
If you wanted to remove the potential ambiguity in the original
sentence then replacing "to" with "at" might do it. Â
On the other hand, warning about offsets that don't fit in 31 bits
seems a tiny bit arbitrary and I don't know if that diagnostic is
actually conveying any useful information in the first place.
p.
More information about the Binutils
mailing list