[AArch64] Don't generate GOT entry for large model TLS LE relocation

Jiong Wang jiong.wang@foss.arm.com
Mon Jan 4 12:40:00 GMT 2016


On 23/12/15 18:10, Marcus Shawcroft wrote:
> On 23 December 2015 at 16:55, Jiong Wang <jiong.wang@foss.arm.com> wrote:
>
>> This patch revert the following commit
>> commit b7a944fea3a0194d81f6de4d958f3a1d2c6ad03a
>> Author: Renlin Li <renlin.li@arm.com>
>> Date:   Fri Oct 2 17:02:53 2015 +0100
> I have not looked at this in detail, I'm out of the office at the
> moment, but I did notice that this is more than a revert!
>
> Please split this into two patches.
>
> 1) The revert request.
> 2) The new functionality you want to add.

OK. Attachment is a pure revert of related commits:

the following two commits:
===

commit b7a944fea3a0194d81f6de4d958f3a1d2c6ad03a
Author: Renlin Li <renlin.li@arm.com>
Date:   Fri Oct 2 17:02:53 2015 +0100

     [BFD][AARCH64]Create GOT section for TLSLE_MOVW_TPREL_G(1, 1_NC, 2).

commit ac734732481451698ee23990aaa64907e56dd082
Author: Renlin Li <renlin.li@arm.com>
Date:   Fri Oct 2 17:22:36 2015 +0100

     [BFD][AARCH64]Add TLSGD relaxation support under large memory model.


And tls relaxation part of:
===
commit 0484b4549e9e2802e2f9db30a61f4b2a76332a8f
Author: Renlin Li <renlin.li@arm.com>
Date:   Fri Oct 2 17:43:08 2015 +0100

     [LD][AARCH64]Add TLSDESC support for large memory model.

no ld regression on both master and 2.26 branch.

OK to master and 2.26 branch?

2016-01-04  Jiong Wang  <jiong.wang@arm.com>

bfd/
   Revert
   2015-10-02  Renlin Li  <renlin.li@arm.com>

         * elfnn-aarch64.c (aarch64_tls_transition_without_check):  Add
         relax transitions for TLSDESC_ADD, TLSDESC_LDR, TLSDESC_OFF_G0_NC,
         TLSDESC_OFF_G1.
         (aarch64_tls_transition_without_check): Add relaxation support.
         (elfNN_aarch64_tls_relax): Likewise.

2015-10-02  Renlin Li  <renlin.li@arm.com>

         * elfnn-aarch64.c(IS_AARCH64_TLS_RELAX_RELOC):
         Add relaxation support for TLSGD_MOVW_G0_NC and TLSGD_MOVW_G1.
         (aarch64_tls_transition_without_check): Likewise
         (elfNN_aarch64_tls_relax): Likwise.

2015-10-02  Renlin Li  <renlin.li@arm.com>

         * elfnn-aarch64.c (elfNN_aarch64_check_relocs): Create GOT section
         for TLSLE_MOVW_TPREL_G(1, 1_NC, 2) relocation.

ld/testsuite/ld-aarch64/
   Revert
   2015-10-02  Renlin Li  <renlin.li@arm.com>

         * ld-aarch64/aarch64-elf.exp: Run new test.
         * ld-aarch64/tls-relax-large-desc-ie.d: New.
         * ld-aarch64/tls-relax-large-desc-ie.s: New.
         * ld-aarch64/tls-relax-large-desc-le.d: New.
         * ld-aarch64/tls-relax-large-desc-le.s: New.

   2015-10-02  Renlin Li  <renlin.li@arm.com>

         * ld-aarch64/aarch64-elf.exp: run new test
         * ld-aarch64/tls-relax-large-gd-ie.d: New.
         * ld-aarch64/tls-relax-large-gd-ie.s: New.
         * ld-aarch64/tls-relax-large-gd-le.d: New.
         * ld-aarch64/tls-relax-large-gd-le.s: New.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: newest.patch
Type: text/x-patch
Size: 17254 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20160104/1e52b795/attachment.bin>


More information about the Binutils mailing list