[PATCH 0/6] misc constification of strings

Nick Clifton nickc@redhat.com
Fri Feb 19 16:28:00 GMT 2016


Hi Trevor,

> thanks, from rebasing some other patches it looks like making the local
> "string" in s_stab_generic () const got dropped, was that intended?

Sorry - snafu - now fixed.

> I also se you made some whitespace fixups, are the rules documented
> somewhere?

Not specifically with regard to whitespace and C types no.  In generic we
try to adhere to the GNU Coding Standards, but that does not define how 
types and variable names are separated.  I personally feel that there 
should be at least one whitespace character between the type name and the
variable name, even if that type is a pointer.  (IE "char * foo;").  But
many other people treat the asterisk as part of the variable name, when
declaring the type.  (IE: "char *foo;").

Cheers
  Nick





More information about the Binutils mailing list