[PATCH] Move 'enum bfd_endian' to a non-generated header

[Pedro Alves]

On 02/18/2016 04:08 PM, Mike Frysinger wrote:
> On 18 Feb 2016 15:15, Pedro Alves wrote:
>> On 02/18/2016 02:59 PM, Nick Clifton wrote:
>>>   Also - why create a new header file ?  Why not just add it to bfdlink.h ?
>>>
>>
>> Unfortunately that wouldn't work, because bfdlink.h depends on types that
>> depend on bfd being configured.  E.g., bfd_vma.
> 
> since bfd.h is already a generated header from multiple inputs, why not
> create a new bfd-in-plain.h (or whatever) file that also gets gathered ?
> then code in-tree can include that directly and out of tree users do not
> need to change anything.

Because I didn't know this was an issue, but I agree that sounds like a good
idea.  I'll give that a try.

> 
>>>   (New header files are a pain for toolchain releases and distribution 
>>>   packagers).
> 
> this is significant.  off the top of my head, there's a few places in
> Gentoo i'd have to adjust, and do so dynamically (since we support old
> versions too).
> -mike
> 

Thanks,
Pedro Alves