[gold commit] PR 19577: Fix build failure in gold due to signed vs. unsigned comparisons
Cary Coutant
ccoutant@gmail.com
Sat Feb 6 18:24:00 GMT 2016
>> - int32_t max = static_cast<int32_t>((1U << bits) - 1);
>> + uint32_t max = static_cast<int32_t>((1U << bits) - 1);
>
> Shouldn't the cast be changed as well?
>> - int64_t max = static_cast<int64_t>((static_cast<uint64_t>(1) << bits) - 1);
>> + uint64_t max = static_cast<int64_t>((static_cast<uint64_t>(1) <<
>> bits) - 1);
>
> Here the cast doesn't make sense any more.
Oops, yes. Thanks. (I blame it on Saturday morning.)
-cary
More information about the Binutils
mailing list