[PATCH] xtensa: fix signedness of gas relocations

augustine.sterling@gmail.com augustine.sterling@gmail.com
Wed Feb 3 17:47:00 GMT 2016


On Wed, Feb 3, 2016 at 12:36 AM, Max Filippov <jcmvbkbc@gmail.com> wrote:
> Change 1058c7532d0b "Use signed data type for R_XTENSA_DIFF* relocation
> offsets." changed signedness of BFD_RELOC_XTENSA_DIFF* relocations
> substituted for BFD_RELOC_*. This made it impossible to encode arbitrary
> 8-, 16- and 32-bit values, which broke e.g. debug info encoding by .loc
> directive. Revert this part and add test.
>
> gas/
> 2016-02-03  Max Filippov  <jcmvbkbc@gmail.com>
>         * config/tc-xtensa.c (md_apply_fix): Mark BFD_RELOC_XTENSA_DIFF*
>         substitutions for BFD_RELOC_* as unsigned.
>
> gas/testsuite/
> 2016-02-03  Max Filippov  <jcmvbkbc@gmail.com>
>         * gas/xtensa/all.exp: Add loc to list of xtensa tests.
>         * gas/xtensa/loc.d: New file: loc test result patterns.
>         * gas/xtensa/loc.s: New file: loc test.

This is OK.



More information about the Binutils mailing list