[PATCH 3/9] Rework RISC-V relocations

Mike Frysinger vapier@gentoo.org
Fri Dec 16 23:39:00 GMT 2016


On 14 Dec 2016 20:23, Palmer Dabbelt wrote:
> +void
> +riscv_pre_output_hook (void)
> +{
> +  frchainS *frchP;

i don't think we normally use this naming style.  if the "p" means
pointer, then write it lower case instead of upper.

> +  asection *s;

should all of pointers in this func be const ?  at a glance, seems like
they should be.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://sourceware.org/pipermail/binutils/attachments/20161216/9e0744e6/attachment.sig>


More information about the Binutils mailing list