[PATCH] GOLD: emit STT_FILE symbols when more than 64k sections

Tristan Gingold gingold@adacore.com
Tue Dec 6 16:11:00 GMT 2016


> On 05 Dec 2016, at 19:44, Cary Coutant <ccoutant@gmail.com> wrote:
> 
>> a simple thinko in object.cc prevents from emitting STT_FILE symbols when --gc-sections is used and when the file contains more than 64K symbols.  See the testcase.
>> 
>> No regression on x86-64 linux.
>> 
>> Ok to commit ?
> 
> Not quite. The real problem was that the is_ordinary flag wasn't being
> checked before we use shndx, and the effect was that any SHN_ABS
> symbol may have been incorrectly omitted. I've applied the attached
> patch.
> 
> Thanks for finding the problem, and for providing a test case!

Thanks for the correct fix.



More information about the Binutils mailing list