[binutils-gdb] Fix handling of MIPS16 HI16 relocs.

Maciej W. Rozycki macro@imgtec.com
Tue Dec 6 00:21:00 GMT 2016


Hi Nick,

On Thu, 1 Dec 2016, Nick Clifton wrote:

>     Fix handling of MIPS16 HI16 relocs.
>     
>     	PR ld/16720
>     	* elfxx-mips.c (mips_elf_calculate_relocation): Remove overflow
>     	test for HI16 relocs.

 Test case?  Also the MIPS psABI does explicitly require an overflow check 
here, so a commentary note is certainly due, perhaps also referencing the 
comment in the switch case immediately below, where `_gp_disp' is handled 
with R_MIPS16_LO16 relocations, which likewise are incorrectly required by 
the psABI to be overflow-checked.

 Thanks for handling the bug report.

  Maciej



More information about the Binutils mailing list