[PATCH] Fixed issue with NULL pointer access on header var.

[Nick Clifton]

Hi Cupertino,

> Variable "header" in function is set conditionally, but was accessed without
> verifying if pointer was NULL.
> 
> opcodes/ChangeLog:
> 
>     Cupertino Miranda  <cmiranda@synopsys.com>
> 	* opcodes/arc-dis.c (print_insn_arc): Changed.

Approved, please apply, but ...

>      case bfd_mach_arc_arcv2:
>      default:
>        isa_mask = ARC_OPCODE_ARCv2EM;
> -      if ((header->e_flags & EF_ARC_MACH_MSK) == EF_ARC_CPU_ARCV2HS)
> +      if (header != NULL 
> +	  && (header->e_flags & EF_ARC_MACH_MSK) == EF_ARC_CPU_ARCV2HS)
>  	{
>  	  isa_mask = ARC_OPCODE_ARCv2HS;
>  	  /* FPU instructions are not extensions for HS.  */

Given that 'header' is only ever used in this particular case, why
not move the declaration and initialisation of header here as well ?

Cheers
  Nick