[PATCH, binutils/ARM] Remove _S version or MSR/MRS special registers

Thomas Preudhomme thomas.preudhomme@foss.arm.com
Mon Aug 15 16:27:00 GMT 2016


Hi Tristan,

Is the below patch ok for binutils-2_27-branch? Pasting original text again for 
convenience:

Hi,

When adding support for ARMv8-M in GAS, MRS/MSR special registers were extended 
with MSP_S/MSP_NS and PSP_S/PSP_NS. While _NS versions make sense as they 
correspond to a different encoding, _S version do not. They are artifacts of 
previous version of the patch where a special CLI switch was considered to 
assemble ARMv8-M Secure code. In their current form they are a source of 
confusion because they would lead to read or write the non secure version of MSP 
and PSP when in non secure state.

Since this is early 2.27 days, we believe it to be best to remove them now 
rather than keep them in. Patch is in attachment.

Best regards,

Thomas


On 15/08/16 11:56, Nick Clifton wrote:
> Hi Thomas,
>
>> *** gas/ChangeLog ***
>> 2016-08-11  Thomas Preud'homme  <thomas.preudhomme@arm.com>
>>
>>         * config/tc-arm.c (v7m_psrs): Remove msp_s, MSP_S, psp_s and PSP_S
>>         special registers.
>>         * testsuite/gas/arm/archv8m-cmse-msr.s: Remove test for above special
>>         registers.
>>         * testsuite/gas/arm/archv8m-cmse-msr-base.d: Likewise.
>>         * testsuite/gas/arm/archv8m-cmse-msr-main.d: Likewise.
>>         * testsuite/gas/arm/archv8m-main-dsp-4.d: Likewise.
>>
>> Is this ok for master and more importantly binutils-2_27-branch?
>
> Approved for mainline.  Check with Tristan for the branch, although I do not forsee any problems.
>
> Cheers
>   Nick
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: remove_s_msr_special_regs.patch
Type: text/x-patch
Size: 5205 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20160815/b599f791/attachment.bin>


More information about the Binutils mailing list