[AArch64] Also puts value in place for R_AARCH64_RELATIVE

Jiong Wang jiong.wang@foss.arm.com
Fri Apr 29 14:27:00 GMT 2016


On 28/04/16 14:15, Nick Clifton wrote:
> Hi Jiong,
>
>> static linking stage for scenario described above.  Meanwhile I noticed
>> old AArch64 android loader has a bug (PR19163) which relies on current
>> linker behavior as a workaround, so the same option --no-apply-dynamic-relocs
>> added.
> The patch looks OK to me, but it is lacking one detail: since you are adding a
> new feature to the linker you need to add some documentation to ld/ld.texinfo
> and mentions it in ld/NEWS.

Thanks for the review, documentation and NEWS updated.

OK for master?

Thanks.

bfd/
   * bfd-in.h (bfd_elf64_aarch64_set_options): Update prototype.
   * bfd-in2.h (bfd_elf64_aarch64_set_options): Likewise.
   * elfnn-aarch64.c (bfd_elfNN_aarch64_set_options): Initialize
   no_apply_dynamic_relocs.
   (elfNN_aarch64_final_link_relocate): Apply absolute relocations even though
   dynamic relocations generated.

ld/
   * emultempl/aarch64elf.em (--no-apply-dynamic-relocs): New option.
   * NEWS: Mention --no-apply-dynamic-relocs.
   * ld.texinfo (ld and the ARM family): Document --no-apply-dynamic-relocs.
   * testsuite/ld-aarch64/rela-abs-relative.s: New test source.
   * testsuite/ld-aarch64/rela-abs-relative.d: New expected result.
   * testsuite/ld-aarch64/rela-abs-relative-be.d: Likewise for big-endian.
   * estsuite/ld-aarch64/rela-abs-relative-opt.d: Likewise, but enable new
   option.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: update.patch
Type: text/x-patch
Size: 8763 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20160429/ef145594/attachment.bin>


More information about the Binutils mailing list