[committed, PATCH] Always create dynsym section with dynamic sections

[H.J. Lu]

On Fri, Apr 22, 2016 at 4:24 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, Apr 22, 2016 at 2:49 PM, Faraz Shahbazker
> <Faraz.Shahbazker@imgtec.com> wrote:
>> On 04/22/2016 12:28 PM, H.J. Lu wrote:
>>> On Fri, Apr 22, 2016 at 11:55 AM, Faraz Shahbazker
>>>> + if (dynsymcount != 0 || elf_hash_table (info)->dynamic_sections_created)
>>>> +     ++dynsymcount;
>>>
>>> Are you saying dynamic_sections_created is 0 for MIPS here
>>> and will become 1 later?
>>
>> No, it will remain 0. The link is static, but the hash_table is still used to
>> record global symbols that have GOT relocations against them. Ofc, this
>> hash_table does not result in creation of a dynsym section, because well,
>> dynamic_sections_created is 0.
>>
>> Check the list of callers to bfd_elf_link_record_dynamic_symbol(), a number of
>> architectures use the link_hash_table in situations where it is not clear whether it is
>> being used to track dynamic symbols for a dynamic executable, as it is for x86.
>>
>
> So MIPS doesn't have dynamic symbols in this case.  It just borrows
> dynsymcount for different purpose.  Is this correct?
>

The comments for elf_link_hash_table say:

  /* The number of symbols found in the link which must be put into
     the .dynsym section.  */
  bfd_size_type dynsymcount;


-- 
H.J.