[PATCH 1/3] opcodes/arc: Compute insn lengths in disassembler

Claudiu Zissulescu Claudiu.Zissulescu@synopsys.com
Thu Apr 7 11:27:00 GMT 2016


Hi,

> +static int
> +arc_insn_length (unsigned isa_mask, bfd_byte msb,
> +                 bfd_byte lsb ATTRIBUTE_UNUSED)
> +{
> +  static int tbl [32]; /* 0x00 -> 0x1f */
> +  static int tbl_init = 0;

Please use bfd_boolean instead of int for tbl_init.

Otherwise, it seems sane to me.

Best,
Claudiu



More information about the Binutils mailing list